Propagate HTTP headers in ExceptionUtil #7352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-matthewb
approved these changes
Jan 22, 2026
|
|
||
| response.reset(); | ||
|
|
||
| securityHeaders.forEach(response::setHeader); |
Contributor
There was a problem hiding this comment.
Should this test response.isCommitted()? Will it throw if setHeader() is called late?
Contributor
Author
There was a problem hiding this comment.
This is all inside of if (!response.isCommitted()). See line 823, just outside the lines shown in the diff.
labkey-tchad
approved these changes
Jan 23, 2026
Member
labkey-tchad
left a comment
labkey-tchad
left a comment
There was a problem hiding this comment.
Manual test didn't turn up any problems and TeamCity seems happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We don't want to reset all HTTP headers when returning a 401 or other error page
Changes
Strict-Transport-Security